Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release-1-13] Prevent classNames from being duplicated. #12784

Merged
merged 2 commits into from
Jan 8, 2016
Merged

[BUGFIX release-1-13] Prevent classNames from being duplicated. #12784

merged 2 commits into from
Jan 8, 2016

Commits on Jan 8, 2016

  1. Add a failing test that checks if classNames in DOM reflect the compo… 

    …nents classNames

(cherry picked from commit 4d587dd)
    @fpauser @Dhaulagiri
    fpauser authored and Dhaulagiri committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    9a2a0d7 View commit details
    Browse the repository at this point in the history

  2. [BUGFIX beta] Prevent classNames from being duplicated. 

    When a component is created we pass all `attrs` as root properties. In
this case, that means that the `classNames` concatenated properties have
already been merged/handled.

The fix is to remove the processing of `attrs.classNames` from
`normalizeClass`, which prevents any classes provided via `classNames`
from being added twice.
    @rwjblue @Dhaulagiri
    rwjblue authored and Dhaulagiri committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    0a22ad5 View commit details
    Browse the repository at this point in the history