Use routing service instead of application controller in test helpers #12766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmwillis
force-pushed
the
test-router
branch
2 times, most recently
from
832011c
to
80875e8
Compare
|
Looks like some versions of IE failed the Sauce tests for unrelated reasons. |
|
Restarted Sauce Labs tests. |
trentmwillis
force-pushed
the
test-router
branch
from
80875e8
to
65172ae
Compare
|
@rwjblue rebased and re-pushed, all is green now |
|
Thank you very much! |
rwjblue
added a commit
that referenced
this pull request
Jan 20, 2016
Use routing service instead of application controller in test helpers
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment.