[DOC Release] Mark multiple methods in Ember.Router as public #12763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem identical, but may be related to #12211 |
|
@acorncom - Ya, definitely related but distinct. @mikepmunroe - I'm unsure if all of these were intended to be public API's. I would like @machty's thoughts here, as he has the most context into the intent.... |
|
I don't think we should mark these public. If there are any of these we definitely need/want, it'd be better to make note of it as part of the Routing Service PR |
|
Closing this. We will add requests to the Routing Service PR, if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark Ember.Router.url as public
Mark Ember.Router.startRouting as public
Mark Ember.Router.isActive as public
Mark Ember.Router.isActiveIntent as public
Mark Ember.Router.hasRoute as public
Mark Ember.Router.reset as public