[BUGFIX beta] Ensure container can still be provided to .create.

[rwjblue]

In Ember versions until 2.3.0 it was common to provide a container property (if needed) when creating instances of a factory manually. This might look like:

let Foo = container.lookupFactory('model:foo');
let instance = Foo.create({
  container
});

Many addons did this (examples include ember-cp-validations and ember-data).

Our initial implementation of the deprecated container property on extendable factories used Object.defineProperty to ensure calling instance.container returned the correct value. Unfortunately, we only defined a getter which means calling Foo.create({ container }); triggers the following error:

Cannot set property container of [object Object] which has only a getter

This change adds a setter (with an appropriate deprecation) to prevent triggering an error.

Without this change, using Ember Data 2.2.0 with Ember 2.3.0 fails.

---

/cc @dgeb

[stefanpenner]

Does this need to be in release? It looks similar to something I swear I saw in release. (But it's possible it was something else)

[rwjblue]

No, ember-inject-owner feature is only in beta. It is possible that there is another related scenario from 2.1's public introduction of ember-container-reform feature. I can look into that later tonight (will make a separate PR if I find additional getter only scenarios like this).

[dgeb]

Great catch @rwjblue. LGTM 👍