Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC release] Remove whitespace from function declaration #12693

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

thomascchen
Copy link
Contributor

Remove extra whitespace from a few function declarations in the docs to conform to the following guideline in the Ember.js JavaScript Style Guide:

  • Keep parenthesis adjacent to the function name when declared or called.
function foo() {
}

foo();

@rwjblue
Copy link
Member

rwjblue commented Dec 8, 2015

Awesome, thank you!

@rwjblue
Copy link
Member

rwjblue commented Dec 8, 2015

@homu r+

@homu
Copy link
Contributor

homu commented Dec 8, 2015

📌 Commit cc325dd has been approved by rwjblue

@homu
Copy link
Contributor

homu commented Dec 8, 2015

⌛ Testing commit cc325dd with merge b4e7752...

homu added a commit that referenced this pull request Dec 8, 2015
…rwjblue

[DOC release] Remove whitespace from function declaration

Remove extra whitespace from a few function declarations in the docs to conform to the following guideline in the [Ember.js JavaScript Style Guide](https://github.com/emberjs/ember.js/blob/master/STYLEGUIDE.md#whitespace):

+ Keep parenthesis adjacent to the function name when declared or called.

```javascript
function foo() {
}

foo();
```
@homu
Copy link
Contributor

homu commented Dec 9, 2015

💥 Test timed out

rwjblue added a commit that referenced this pull request Dec 9, 2015
…pace

[DOC release] Remove whitespace from function declaration
@rwjblue rwjblue merged commit cb980bc into emberjs:master Dec 9, 2015
@rwjblue
Copy link
Member

rwjblue commented Dec 9, 2015

Thank you! (Not sure why homu's build timed out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants