Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include NaN as a falsey value in the with helper's docstring #12664

Merged

Conversation

balinterdi
Copy link
Contributor

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Dec 1, 2015

Can you confirm that we have tests for NaN (so that these docs are backed up by the tests)?

@balinterdi
Copy link
Contributor Author

Sorry, meant to link the test where I actually verified NaNs should not be displayed. Here it is:
https://github.com/emberjs/ember.js/blob/v2.2.0/packages/ember-views/tests/streams/streams-test.js#L16

@rwjblue
Copy link
Member

rwjblue commented Dec 1, 2015

Awesome, thank you!

rwjblue added a commit that referenced this pull request Dec 1, 2015
…helper

Include NaN as a falsey value in the `with` helper's docstring
@rwjblue rwjblue merged commit f455bc9 into emberjs:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants