Access property only once during Ember.get
#12485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmwillis
changed the title
Ember.get
| @@ -76,10 +76,10 @@ export function get(obj, keyName) { | |||
| if (meta && meta.peekWatching(keyName) > 0) { | |||
| ret = meta.peekValues(keyName); | |||
| } else { | |||
| ret = obj[keyName]; | |||
| ret = possibleDesc; | |||
There was a problem hiding this comment.
var name should be different, as in this position (and bellow) it actually cannot be a descriptor any-longer.
There was a problem hiding this comment.
Preference on the new name? value? keyValue?
|
I think the CI may need to be re-run. Says tests failed on two version of IE, but the failures are related to the |
stefanpenner
added a commit
that referenced
this pull request
Oct 16, 2015
Access property only once during `Ember.get`
|
thanks @trentmwillis, this is a nice cleanup. I would love for us to continue to tighten up these internals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside of
Ember.get, there are cases where the property on an object will get accessed more than once for a single call. In most cases this isn't a problem, but if the object has a getter defined on it then we wind up doing extra work and incurring a performance hit.