[BUGFIX release-1-13] Add deprecation options to some 1.13 deprecations #12481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ember.deprecate(`You manually rerendered ${label} (a parent component) from a child component during the rendering process. This rarely worked in Ember 1.x and will be removed in Ember 2.0`); | ||
| Ember.deprecate(`You manually rerendered ${label} (a parent component) from a child component during the rendering process. This rarely worked in Ember 1.x and will be removed in Ember 2.0`, | ||
| false, | ||
| { id: 'ember-views.manual-parent-rerender', until: '3.0.0' }); |
There was a problem hiding this comment.
In the 2.0 release these were marked 3.0.0, even though in the text of the message it says its going away in 2.0. Should I update the message too?
There was a problem hiding this comment.
it is already changed in master, and should be changed to 3.0 here
|
A PR for issue #12478 |
mixonic
added a commit
that referenced
this pull request
Nov 5, 2015
[BUGFIX release-1-13] Add deprecation options to some 1.13 deprecations
mixonic
added a commit
that referenced
this pull request
Nov 5, 2015
|
Merged and I added the cleanup myself in 223ddd2 Thanks @toddjordan ! |
|
Thanks @mixonic 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added deprecation options to some deprecation warnings I was commonly getting in going from 1.13 to 2.0. This is probably not all the un-optioned deprecations, but they cover the ones I've seen so far. This hopefully will help others going through the same process.