Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Ensure rest arg positionalParams can be omitted. #12445

Merged
merged 1 commit into from
Oct 6, 2015

Commits on Oct 6, 2015

  1. [BUGFIX release] Ensure rest arg positionalParams can be omitted.

    When specifying `postionalParams` like this:
    
    ```javascript
    App.FooBarComponent = Ember.Component.extend();
    
    App.FooBarComponent.reopenClass({
      positionalParams: 'allTheThings'
    });
    ```
    
    You should be able to avoid using positional params by specifying
    `allTheThings` as a hash argument:
    
    ```hbs
    {{foo-bar allTheThings=blah}}
    ```
    
    Unfortunately, we were triggering an assertion that you used a positional
    param that conflicted with a hash param.  This change fixes that
    assertion by avoiding doing any work when no params are specified.
    rwjblue committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    d34aa11 View commit details
    Browse the repository at this point in the history