[BUGFIX beta] Allow call, apply to trigger _super wrapping.
#12359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
the-bastard
branch
from
211cfb3
to
d6eb98c
Compare
mixonic
changed the title
_super wrapping.
|
Now updated to be a PR with |
mixonic
force-pushed
the
the-bastard
branch
2 times, most recently
from
b113b23
to
57b9577
Compare
For CP macros (and other possible cases), `call` or `apply` may be used to redirect what seems like the "method" of a property. These cases should be wrapped in case they use `_super`, much as the explicit check for `_super` usages causes the method to be wrapped.
mixonic
force-pushed
the
the-bastard
branch
from
57b9577
to
64e40c2
Compare
rwjblue
added a commit
that referenced
this pull request
Sep 18, 2015
[BUGFIX beta] Allow call, apply to trigger `_super` wrapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the new
_superlogic coming in 2.1 appears to have a slightly different behavior than that of 2.0 regarding making_superavailable to CPs. Because the getter function of thismacrodoes not contain the stringthis._super, the super is not provided (andROOTis incorrectly used instead).This change wraps methods using
callandapplyin addition to those using_superin case super is called.