[WIP] Various component perf improvements #12286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wycats
force-pushed
the
glimmer-component-perf
branch
from
098f729
to
4088a23
Compare
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "features": { | |||
| "features-stripped-test": null, | |||
| "ember-htmlbars-component-generation": null, | |||
| "ember-htmlbars-component-generation": true, | |||
There was a problem hiding this comment.
This will need to be changed back to null before merging.
Previously, we tried to restrict which attributes we set eagerly, and clean up the rest using unknownProperty. However, over time, making that work correctly has gotten more and more complicated, and the cost of the laziness is more than the benefits. This commit goes back to an eager setting strategy, eliminates unknownProperty and the reliance on _internalDidReceiveAttrs. It leaves a setter interceptor for propagating sets to mutable cells.
Similar to `meta`, this commit restructures the scope away from pervasive use of `Object.create` into a custom JavaScript object. This has two benefits: 1. We only need a single parent pointer, rather than having every map inherit from its parent map. 2. v8 penalizes us for using `Object.create` by often assuming we are creating something more class-like and eventually blowing up methods that use scopes. Eventually, this scope refactoring will probably replace some of the hooks in HTMLBars.
wycats
force-pushed
the
glimmer-component-perf
branch
from
4088a23
to
43b39f8
Compare
|
Cleaned up comments and merged in #12289. |
|
are there some perf #'s? Im nervous to merge perf work, without actual metrics to go along |
|
@stefanpenner - Sorry for not including them initially. I added the numbers to the description in #12289, but here is a snapshot: |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet. I need to squash the commits. I'm making a PR so I can get line comments.