[BUGFIX release] Ensure _actions specified to extend works.
#12188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial deprecation of `_actions` and moving it to `actions` was a bit too naive. The `deprecateProperty` helper was used, which meant that when `_actions` was set, it would call `set(this, 'actions', newValue)`. This meant that passing `_actions` to `Ember.Route.extend` (or `.reopen`) resulted in the `_actions` completely clobbering `actions` (and loosing any previously defined actions there). The fix was to: * Replace the generic `deprecateProperty` usage with a custom `Object.defineProperty` call, that defines a setter with an assertion instead of clobbering. * Implementing a `willMergeMixin` that mutates the `props` at extend time (to ensure that `_actions` is moved to `actions` with a deprecation).
rwjblue
added a commit
that referenced
this pull request
Aug 24, 2015
[BUGFIX release] Ensure `_actions` specified to extend works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial deprecation of
_actionsand moving it toactionswas a bit too naive. ThedeprecatePropertyhelper was used, which meant that when_actionswas set, it would callset(this, 'actions', newValue). This meant that passing_actionstoEmber.Route.extend(or.reopen) resulted in the_actionscompletely clobberingactions(and loosing any previously defined actions there).The fix was to:
deprecatePropertyusage with a customObject.definePropertycall, that defines a setter with an assertion instead of clobbering.willMergeMixinthat mutates thepropsat extend time (to ensure that_actionsis moved toactionswith a deprecation).Fixes #12081.
Thanks to @kimroen for helping track this down.