[BUGFIX beta] Allow deprecated access to registry. #12157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the `ember-registry-container-reform` the registry was moved from `Application#registry` / `ApplicationInstance#registry` to `__registry__`, and a new public API was created allowing access to the majority of functions that folks used directly on `Application` or `ApplicationInstance` instances. We created an alias `container` property for `ApplicationInstances`, but missed creating the same thing for `registry` which was exposed non-underscored on both `Application` and `ApplicationInstance` instances. This adds an alias for all public `registry` methods at their original location and provides a helpful deprecation warning instructing you what to use instead. Also, changes the `ApplicationInstance` `Object.defineProperty` calls to be done once on the `ApplicationInstance` prototype (instead of on each instance).
|
@dgeb - Would love your review on this, as you are the most familiar with the ember-registry-container-reform feature? |
bmac
added a commit
to bmac/data
that referenced
this pull request
Aug 20, 2015
This way Ember Data won't log deprecation warnings when emberjs/ember.js#12157 lands in Ember.
bmac
added a commit
to bmac/data
that referenced
this pull request
Aug 20, 2015
This way Ember Data won't log deprecation warnings when emberjs/ember.js#12157 lands in Ember.
bmac
added a commit
to emberjs/data
that referenced
this pull request
Aug 20, 2015
This way Ember Data won't log deprecation warnings when emberjs/ember.js#12157 lands in Ember. (cherry picked from commit c08f725)
rwjblue
added a commit
that referenced
this pull request
Aug 22, 2015
…istry-functions [BUGFIX beta] Allow deprecated access to registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the
ember-registry-container-reformthe registry was moved fromApplication#registry/ApplicationInstance#registryto__registry__, and a new public API was created allowing access to the majority of functions that folks used directly onApplicationorApplicationInstanceinstances.We created an alias
containerproperty forApplicationInstances, but missed creating the same thing forregistrywhich was exposed non-underscored on bothApplicationandApplicationInstanceinstances.This adds an alias for all public
registrymethods at their original location and provides a helpful deprecation warning instructing you what to use instead.Also, changes the
ApplicationInstanceObject.definePropertycalls to be done once on theApplicationInstanceprototype (instead of on each instance).This fixes a regression that was reported in a number of prominent projects: