[BUGFIX release] Fix link-to with only qps linking to outdated route #12058
Conversation
| @@ -320,7 +320,7 @@ var LinkComponent = EmberComponent.extend({ | |||
| } | |||
|
|
|||
| var routing = get(this, '_routing'); | |||
| var targetRouteName = get(this, 'targetRouteName'); | |||
| var targetRouteName = this._handleOnlyQueryParamsSupplied(get(this, 'targetRouteName')); // Fixed version | |||
There was a problem hiding this comment.
I don't understand this comment. Can you flesh it out more or delete?
There was a problem hiding this comment.
I just forgot to delete it.
cibernox
force-pushed
the
fix_qps_only_links
branch
from
aea059b
to
296d359
Compare
cibernox
force-pushed
the
fix_qps_only_links
branch
from
296d359
to
1b63604
Compare
|
👍 experience the same bug. Great that there is a fix for it already. |
| @@ -320,7 +320,7 @@ var LinkComponent = EmberComponent.extend({ | |||
| } | |||
|
|
|||
| var routing = get(this, '_routing'); | |||
| var targetRouteName = get(this, 'targetRouteName'); | |||
| var targetRouteName = this._handleOnlyQueryParamsSupplied(get(this, 'targetRouteName')); | |||
There was a problem hiding this comment.
This looks good to me but in hindsight, but in hindsight we should probably find a better name for this method... it doesn't seem to "handle" anything but rather compute the target route name? @juggy, you're the original author, would you be ok with renaming this method or is there something I'm missing?
There was a problem hiding this comment.
but in hindsight, but in hindsight
does this reduce to "in the future " 
There was a problem hiding this comment.
Yes it can be renamed to something more meaningful like computeWithOnlyQueryParamsSupplied.
|
Added a comment which might be beyond the scope of this PR but might be worth a quick fix if @juggy is quick enough to respond, else we can just merge. |
[BUGFIX release] Fix link-to with only qps linking to outdated route
Fixes #12033
Once a link with only qps was created in a certain route, the
targetRouteNamewas never updated again (the URL however was updated properly)