Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Remove internal use of Em.String.fmt & mark as deprecated #11959

Merged
merged 1 commit into from
Aug 3, 2015

Conversation

cibernox
Copy link
Contributor

@cibernox cibernox commented Aug 2, 2015

Resurrection of #10861

Basically the rebase was so complex that was faster to just do it again.

I've removed all internal usages of fmt and documented it as @deprecated, but I haven't added any real deprecation because I wasn't sure if that was the desired thing.
If you feel that we're are in time for removing this, I'll update this same PR with the deprecation warning and create another one removing the feature for good.

@justinwoo
Copy link
Contributor

👍 🍔

@rwjblue
Copy link
Member

rwjblue commented Aug 2, 2015

👍 to removing internal usage, and adding a deprecation for Ember.String.fmt for removal in 3.0.0.

@rwjblue
Copy link
Member

rwjblue commented Aug 3, 2015

Merging this, to prevent crazy rebase hell again, but I'd love another PR adding a deprecation (until: '3.0.0') for Ember.String.fmt.

rwjblue added a commit that referenced this pull request Aug 3, 2015
[BUGFIX beta] Remove internal use of Em.String.fmt & mark as deprecated
@rwjblue rwjblue merged commit 57b1f22 into emberjs:master Aug 3, 2015
@cibernox cibernox deleted the remove-internal-usage-string-fmt branch August 3, 2015 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants