[CLEANUP beta] Abstract chainWatchers into an object. #11819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krisselden is green! |
| }, | ||
|
|
||
| revalidateAll() { | ||
| for (let key in this.nodes) { |
There was a problem hiding this comment.
do we ever delete from this.nodes?
There was a problem hiding this comment.
no, we just empty the array
There was a problem hiding this comment.
@stefanpenner should it just search a single array or linked list of well shaped entries? like {key: 'foo', node: node} ?
There was a problem hiding this comment.
array should be good, as we just do a sequential scan anyways.
|
@krisselden whats blocking this/ |
| // a map of nodes that reference a key | ||
| function ChainWatchers(src) { | ||
| this.src = src; | ||
| this.nodes = Object.create(null); |
There was a problem hiding this comment.
function Empty() {}
Empty.prototype = Object.create(null);
...
this.nodes = new Empty();
krisselden
force-pushed
the
abstract-chainwatchers
branch
from
4c2cc1f
to
95d3f3f
Compare
krisselden
force-pushed
the
abstract-chainwatchers
branch
from
95d3f3f
to
2f63cab
Compare
|
@stefanpenner rebased and squashed |
rwjblue
added a commit
that referenced
this pull request
Jul 24, 2015
[CLEANUP beta] Abstract chainWatchers into an object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracting chainWatchers into an Object, cleans up some shape deopts, helps make stuff more clear. This is good to go, I haven't squashed yet just so it is easier for people to review updates.