Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in sanitation for URLs with more than one slash in it #11801

Closed

Conversation

jonathanKingston
Copy link
Contributor

Fixes: #10937

@stefanpenner
Copy link
Member

needs test + squash – may also be a bugfix.

@jonathanKingston
Copy link
Contributor Author

@stefanpenner will do, was committing so it didn't get lost. Which yeah two core devs proved I should have done that when I wrote it :D.

@rwjblue
Copy link
Member

rwjblue commented Aug 2, 2015

@jonathanKingston - needs a test still

@rwjblue
Copy link
Member

rwjblue commented Aug 9, 2015

Needs to be squashed and a test added...

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2015

Still needs tests, rebase, and squashing.

@jonathanKingston
Copy link
Contributor Author

@rwjblue I have actually simplified this as @tomdale asked to just prefix with the sites window.location.origin

However was not sure of:

  • Would the test be better as a unit test or integration?
  • Do I need to shim window.location.origin as browser support is IE 11+ (I couldn't see one as part of babel or Ember)

@rwjblue
Copy link
Member

rwjblue commented Aug 23, 2015

Do I need to shim window.location.origin as browser support is IE 11+

Yes, we will need some sort of shim.

Would the test be better as a unit test or integration?

I think integration test would be best, but true integration tests using location are pretty hard (because changing location messes up the running tests) so a unit test would probably be fine.

@rwjblue
Copy link
Member

rwjblue commented Apr 10, 2016

Closing as this seems to have gone stale, I'm happy to reopen if you would like to pick this back up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants