-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in sanitation for URLs with more than one slash in it #11801
Conversation
needs test + squash – may also be a bugfix. |
@stefanpenner will do, was committing so it didn't get lost. Which yeah two core devs proved I should have done that when I wrote it :D. |
@jonathanKingston - needs a test still |
Needs to be squashed and a test added... |
Still needs tests, rebase, and squashing. |
@rwjblue I have actually simplified this as @tomdale asked to just prefix with the sites However was not sure of:
|
Yes, we will need some sort of shim.
I think integration test would be best, but true integration tests using location are pretty hard (because changing location messes up the running tests) so a unit test would probably be fine. |
Closing as this seems to have gone stale, I'm happy to reopen if you would like to pick this back up again. |
Fixes: #10937