[CLEANUP BETA] Remove context switching {{with foo}} support
#11790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the |
| ok(destroyed, 'controller was destroyed properly'); | ||
| }); | ||
|
|
||
| QUnit.test('destroys the controller generated with {{with foo as bar controller=\'blah\'}}', function() { |
There was a problem hiding this comment.
Lets keep this test, it isn't using the deprecated context switching form (it may be removed/tweaked in another PR related to the controller= option with {{with}}).
|
Left one minor comment but it looks good, thanks for tackling this! |
topaxi
force-pushed
the
remove-context-switching-with
branch
from
c36e8b3
to
d99aa3e
Compare
|
I've re-added the test you mentioned. |
stefanpenner
added a commit
that referenced
this pull request
Jul 17, 2015
[CLEANUP BETA] Remove context switching `{{with foo}}` support
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11784
I'm not a 100% sure, but I might have killed off too much unit-tests?
They did seem to relate to
{{#with}}though.