Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove Enumerable.rejectProperty #11706

Merged
merged 1 commit into from
Jul 10, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions packages/ember-runtime/lib/mixins/enumerable.js
Original file line number Diff line number Diff line change
Expand Up @@ -472,20 +472,6 @@ export default Mixin.create({
return this.reject(use);
},

/**
Returns an array with the items that do not have truthy values for
key. You can pass an optional second argument with the target value. Otherwise
this will match any property that evaluates to false.

@method rejectProperty
@param {String} key the property to test
@param {String} [value] optional value to test against.
@return {Array} rejected array
@deprecated Use `rejectBy` instead
@private
*/
rejectProperty: aliasMethod('rejectBy'),

/**
Returns the first item in the array for which the callback returns true.
This method works similar to the `filter()` method defined in JavaScript 1.6
Expand Down
6 changes: 0 additions & 6 deletions packages/ember-runtime/tests/suites/enumerable/reject.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,4 @@ suite.test('should match undefined, null, or false properties without second arg
deepEqual(obj.rejectBy('foo'), ary.slice(2), 'rejectBy(\'foo\')\')');
});

suite.test('should be aliased to rejectProperty', function() {
var ary =[];

equal(ary.rejectProperty, ary.rejectBy);
});

export default suite;