Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Ensure local state can shadow attrs. #11572

Merged
merged 1 commit into from
Jun 28, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 28, 2015

We initially intended to deprecate access to local state (ala proxying to attrs) at this location, but we have decided to hold off on that deprecation until angle bracket component invocation is available.

Later in the integration efforts, we added an AttrsProxy to handle most of this functionality for us (when using a View inheritor). In the future, the deprecation will almost certainly be added in the AttrsProxy (not getRoot hook).


Prior to this change local state could never use the same name as a value in attrs (because the attrs always "won").

The else case is still present, when a given template is not backed by a view/component instance.

Fixes #11559
Fixes #11571

We initially intended to deprecate access to local state (ala proxying
to attrs) at this location, but we have decided to hold off on that
deprecation until angle bracked component invocation is available.

Later in the integration efforts, we added an AttrsProxy to handle most
of this functionality for us (when using a View inheritor). In the
future, the deprecation will almost certainly be added in the
`AttrsProxy` (not `getRoot` hook).
---

Prior to this change local state could never use the same name as a
value in `attrs` (because the `attrs` always "won").

The else case is still present, when a given template is not backed by a
view/component instance.
@stefanpenner
Copy link
Member

LGTm

rwjblue added a commit that referenced this pull request Jun 28, 2015
…attrs

[BUGFIX release] Ensure local state can shadow attrs.
@rwjblue rwjblue merged commit 2e505cd into emberjs:master Jun 28, 2015
@rwjblue rwjblue deleted the ensure-local-state-can-shadow-attrs branch June 28, 2015 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants