[BUGFIX beta] Don't dispatch new lifecycle hooks to views #11229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for #11143
Since 84c2875, the lifecycle hooks are inconsistent between views and
components. For example, the
willReceiveAttrs
hook has been renamed todidReceiveAttrs
on components but not on views. Talked to @wycats about it,the plan is "to remove all of the new lifecycle hooks from views", because
"views are sufficiently crazy that I don't want to try to mix in new semantics".
In this commit:
didUpdate
fromView
swillReceiveAttrs
fromView
swillRender
to_willRender
onView
s (for now)willUpdate
to_willUpdate
onView
s (for now)TODO:
View
s to not use_willRender
View
s to not use_willUpdate
_willRender
fromView
s_willUpdate
fromView
s@wycats can you c/d if this is on the right track?