[Bugfix] {{#with}} helper should not render if passed variable is falsey

[joeruello]

Tried out Glimmer in my app and found that {{#with bar as |foo|}} blocks would still render their templates if bar is falsey, which on release, they don't. Thought I would have a go at a fix.

JSBins: Release - Canary

First actual code PR so, let me know if their's anything additional I need to do.

[joeruello]

Was looking around and saw #10961 and ##11019.

Looks like in 1.10, {{#with}} would not render the template if the value was null or undefined, but would render 0, "" and false. I think this is the behaviour is Ember.isNone()?

1.11 changed it to a pure falsey check, which is what my PR is based off.

I couldn't find this behavior documented anywhere except for a maybe a cryptic comment on the API docs // posts might not be. So I'm not sure what to do :)

[rwjblue]

Thank you!

[rwjblue]

Shoot, I forgot to ask, would you mind submitting another PR adding to the API docs?

[joeruello]

Sure, happy to.

Before I do, is the 1.11 behaviour correct? Should we be checking for falsey or just null and undefined?

[rwjblue]

I like that this PR makes it the same truthiness as {{if}}. That makes it pretty easy to understand and consistent with the rest of the system.

[joeruello]

Great, will get another PR up soon.
On 7 May 2015 10:46 pm, "Robert Jackson" [email protected] wrote:

I like that this PR makes it the same truthiness as {{if}}. That makes it
pretty easy to understand and consistent with the rest of the system.

—
Reply to this email directly or view it on GitHub
#11035 (comment).