[BUGFIX beta] Warn rather than raise readOnly CPs #10966
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CPs with setters would raise an exception if they were
marked as readOnly. This change broke Semantic Versioning because
it caused working app code to break.
For example, if you had a computed property that was read-only, but you
happened to include a second
value
argument out of habit orconvention, this change would cause your previously-functioning app to
break:
The above code example will cause an exception to be raised.
In Ember 2.0 we can change this deprecation back to an assertion.