Fix replace in #10883
Merged
Fix replace in #10883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, can you prefix the commit with Thoughts? |
|
It seems that not many are relying on this functionality since it stayed in for a bit. I'm not in dire need of this fix, I just ran across it when updating my ember-islands addon. For now I've prefixed it with [BUGFIX beta]. |
|
👍 - We can revisit if it becomes a more widespread issue. |
|
Restarting Sauce Labs build. |
|
Kicking saucelabs again. |
|
@rwjblue sauce is now happy, should we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10881
The original test failed to reload the child elements after replacing and did not detect this regression. I fixed and refactored this test for clarity.