Don’t share view registry across containers #10599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all rendered views were inserted into the Ember.View.views global hash, indexed by their `elementId`. This hash is used by the EventDispatcher to locate views, and is also used by some advanced developers as a debugging aid. Unfortunately, using a global shared store of views is problematic in the FastBoot/application instance case, since multiple views with the same elementId can exist at the same time. This creates a race condition where the second view to be created will throw an exception, as Ember believes that a view with that element ID has already been created (normally an error in “single app” mode). This commit introduces the notion of a “view registry”, which is just a simple hash injected onto views and shared container-wide. Because each application instance in FastBoot has its own container, these views will naturally be isolated. To preserve backwards-compatibility, the default instance created when the app is booting normally (i.e., autoboot is `false`) injects the global Ember.View.views hash. We should consider removing this entirely in Ember 2.0, now that the Container pane of the Inspector gives developers easier access to registered views. Do note, however, that the Event Dispatcher still has a dependency on the global Ember.View.views, though it could be relatively easily refactored to also have the view registry injected.
| @@ -21,8 +21,8 @@ merge(inDOM, { | |||
| // Register the view for event handling. This hash is used by | |||
| // Ember.EventDispatcher to dispatch incoming events. | |||
| if (!view.isVirtual) { | |||
| Ember.assert("Attempted to register a view with an id already in use: "+view.elementId, !View.views[view.elementId]); | |||
| View.views[view.elementId] = view; | |||
| Ember.assert("Attempted to register a view with an id already in use: "+view.elementId, !view._viewRegistry[view.elementId]); | |||
There was a problem hiding this comment.
Would probably want to move these asserts to the _register function
|
@igorT I've updated the PR to incorporate your suggestions, thank you! |
|
💯 |
mixonic
added a commit
that referenced
this pull request
Mar 10, 2015
Don’t share view registry across containers
|
@tomdale we should inject the view registry on the event dispatcher both of which should be in the container for 2.0 |
|
@krisselden Yep, planning that for a future refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all rendered views were inserted into the Ember.View.views global hash, indexed by their
elementId. This hash is used by the EventDispatcher to locate views, and is also used by some advanced developers as a debugging aid.Unfortunately, using a global shared store of views is problematic in the FastBoot/application instance case, since multiple views with the same elementId can exist at the same time. This creates a race condition where the second view to be created will throw an exception, as Ember believes that a view with that element ID has already been created (normally an error in “single app” mode).
This commit introduces the notion of a “view registry”, which is just a simple hash injected onto views and shared container-wide. Because each application instance in FastBoot has its own container, these views will naturally be isolated.
To preserve backwards-compatibility, the default instance created when the app is booting normally (i.e., autoboot is
false) injects the global Ember.View.views hash. We should consider removing this entirely in Ember 2.0, now that the Container pane of the Inspector gives developers easier access to registered views. Do note, however, that the Event Dispatcher still has a dependency on the global Ember.View.views, though it could be relatively easily refactored to also have the view registry injected.