[BUGFIX beta] Maintain Ember.subscribe compatibility #10436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgwhite this should be Great catch, thanks. |
jgwhite
changed the title
jgwhite
force-pushed
the
instrument-subscribe
branch
from
6723177
to
869b681
Compare
|
@mixonic updated the naming, good call. Thanks for the prod on the PR name. |
jgwhite
force-pushed
the
instrument-subscribe
branch
from
869b681
to
e3919fd
Compare
|
Not completely clear whether these CI failures are a result of the patch or not. |
|
I believe that #10437 will fix the issue we are having. |
|
@jgwhite - Can you rebase? |
…clobbered by stream equivalents
jgwhite
force-pushed
the
instrument-subscribe
branch
from
e3919fd
to
60a1f25
Compare
|
@rwjblue done. |
rwjblue
added a commit
that referenced
this pull request
Feb 13, 2015
[BUGFIX beta] Maintain Ember.subscribe compatibility
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures
instrument.{subscribe,unsubscribe,reset}aren’t clobbered by stream equivalents.Addresses #10435