-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up boot process #10271
Merged
Merged
Clean up boot process #10271
Commits on Jan 29, 2015
-
This is the beginning of a refactor that improves the clarity and explicitness of the Application boot process. In particular, it takes advantage of the previous ApplicationInstance refactoring, and explicitly exposes boot phases via promises. The end-game here is to allow FastBoot to boot up an application but not create an application instance, and allow individual FastBoot requests to create instances on demand. This will also help the testing infrastructure, which also wants to boot an application once for the entire test suite, and create an instance for each test run.
Configuration menu - View commit details
-
Copy full SHA for 0fcd12c - Browse repository at this point
Copy the full SHA 0fcd12cView commit details -
Legacy -> deprecated method naming
Shout out to @rwjblue
Configuration menu - View commit details
-
Copy full SHA for e01cc46 - Browse repository at this point
Copy the full SHA e01cc46View commit details -
This test had its heart in the right place, but the semantics it actually exercises are unimportant and simply tested the side-effects of a previous implementation. To wit, this test sets the application’s location to `none`, yet still expects the application’s `rootURL` to be injected on _any_ arbitrary location looked up via the container. Under the hood, the router registered a private (dash-prefixed) injection, so we feel confident we can refactor the internal implementation without breaking any apps. In short, this test was testing the side-effects of a private injection, which we are eliminating, while retaining the public API it supported.
Configuration menu - View commit details
-
Copy full SHA for d734119 - Browse repository at this point
Copy the full SHA d734119View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66ac1b3 - Browse repository at this point
Copy the full SHA 66ac1b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d26044e - Browse repository at this point
Copy the full SHA d26044eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7629aa - Browse repository at this point
Copy the full SHA b7629aaView commit details -
A registry's fallback registry resolves registrations and injections when no matches can be found.
Configuration menu - View commit details
-
Copy full SHA for ebfa23d - Browse repository at this point
Copy the full SHA ebfa23dView commit details -
Create a registry per ApplicationInstance
The instance's registry sets its fallback to the corresponding application's registry.
Configuration menu - View commit details
-
Copy full SHA for f0aa387 - Browse repository at this point
Copy the full SHA f0aa387View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0862c52 - Browse repository at this point
Copy the full SHA 0862c52View commit details -
Move validation of
fullName
parsing to_parseName
.Ensure that `name` and `type` are valid after initial parsing and before any post-parsing mutations might be performed. This fixes a problem in which mutations are performed to the cached object (e.g. "route:basic" -> "route:") and then the validation of the mutated object fail when it's accessed a second time. It's also more efficient, since validation only occurs once.
Configuration menu - View commit details
-
Copy full SHA for cd499b0 - Browse repository at this point
Copy the full SHA cd499b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for be6a683 - Browse repository at this point
Copy the full SHA be6a683View commit details
Commits on Jan 30, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 1d08c84 - Browse repository at this point
Copy the full SHA 1d08c84View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8ed6cb - Browse repository at this point
Copy the full SHA c8ed6cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fb11dd - Browse repository at this point
Copy the full SHA 9fb11ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for f578a04 - Browse repository at this point
Copy the full SHA f578a04View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.