Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up boot process #10271

Merged
merged 15 commits into from
Jan 30, 2015
Merged

Clean up boot process #10271

merged 15 commits into from
Jan 30, 2015

Commits on Jan 29, 2015

  1. Clean up boot process

    This is the beginning of a refactor that improves the clarity and
    explicitness of the Application boot process. In particular, it takes
    advantage of the previous ApplicationInstance refactoring, and
    explicitly exposes boot phases via promises.
    
    The end-game here is to allow FastBoot to boot up an application but
    not create an application instance, and allow individual FastBoot
    requests to create instances on demand.
    
    This will also help the testing infrastructure, which also wants to boot
    an application once for the entire test suite, and create an instance
    for each test run.
    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    0fcd12c View commit details
    Browse the repository at this point in the history
  2. Legacy -> deprecated method naming

    Shout out to @rwjblue
    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    e01cc46 View commit details
    Browse the repository at this point in the history
  3. Removes location test

    This test had its heart in the right place, but the semantics it
    actually exercises are unimportant and simply tested the side-effects
    of a previous implementation.
    
    To wit, this test sets the application’s location to `none`, yet still
    expects the application’s `rootURL` to be injected on _any_ arbitrary
    location looked up via the container.
    
    Under the hood, the router registered a private (dash-prefixed)
    injection, so we feel confident we can refactor the internal
    implementation without breaking any apps.
    
    In short, this test was testing the side-effects of a private injection,
    which we are eliminating, while retaining the public API it supported.
    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    d734119 View commit details
    Browse the repository at this point in the history
  4. More granular control over routing start

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    66ac1b3 View commit details
    Browse the repository at this point in the history
  5. Implement Application’s visit() API

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    d26044e View commit details
    Browse the repository at this point in the history
  6. Always resolve the boot promise, even in autoboot

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    b7629aa View commit details
    Browse the repository at this point in the history
  7. Introduce fallback registry.

    A registry's fallback registry resolves registrations and injections
    when no matches can be found.
    dgeb authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    ebfa23d View commit details
    Browse the repository at this point in the history
  8. Create a registry per ApplicationInstance

    The instance's registry sets its fallback to the corresponding
    application's registry.
    dgeb authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    f0aa387 View commit details
    Browse the repository at this point in the history
  9. Fix module name

    dgeb authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    0862c52 View commit details
    Browse the repository at this point in the history
  10. Move validation of fullName parsing to _parseName.

    Ensure that `name` and `type` are valid after initial parsing and before
    any post-parsing mutations might be performed.
    
    This fixes a problem in which mutations are performed to the cached
    object (e.g. "route:basic" -> "route:") and then the validation of the
    mutated object fail when it's accessed a second time.
    
    It's also more efficient, since validation only occurs once.
    dgeb authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    cd499b0 View commit details
    Browse the repository at this point in the history
  11. Use imported run

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    be6a683 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2015

  1. Add feature flag for visit API

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    1d08c84 View commit details
    Browse the repository at this point in the history
  2. Add test for disabling autoboot

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    c8ed6cb View commit details
    Browse the repository at this point in the history
  3. Adds simple visit() test

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    9fb11dd View commit details
    Browse the repository at this point in the history
  4. Fix feature flagged autoboot

    tomdale committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    f578a04 View commit details
    Browse the repository at this point in the history