[BUGFIX] Ember.get returns 'length' of null #3760
Labels
Comments
|
Closing in favor of PR: #3852. |
mixonic
added a commit
to mixonic/ember.js
that referenced
this issue
Nov 24, 2014
* Changes globals to only mean properties starting with $ or a capital letter.
* Changes normalizeTuple(obj, 'Foo') to resolve Foo as a global. This
makes the behavior consistent with normalizeTuple(obj, 'Foo.bar') which
already resolves Foo as a global (and looks up bar).
* Changes normalizeTuple(null, 'Foo') to resolve Foo as a global.
* Specs normalizeTuple('null', 'foo') to resolve to [undefined, '']. This
is unfortunate but needed to keep getPath happy.
This code is old, and tricky to modify due to perf optimizations and
edge case behavior. It would be great to refactor more heavily at some
other date. I've spec'd out more of the current behavior and edge cases
in this commit.
Fixes emberjs#3760
mixonic
added a commit
to mixonic/ember.js
that referenced
this issue
Mar 8, 2015
* Changes globals to only mean properties starting with $ or a capital letter.
* Changes normalizeTuple(obj, 'Foo') to resolve Foo as a global. This
makes the behavior consistent with normalizeTuple(obj, 'Foo.bar') which
already resolves Foo as a global (and looks up bar).
* Changes normalizeTuple(null, 'Foo') to resolve Foo as a global.
* Specs normalizeTuple('null', 'foo') to resolve to [undefined, '']. This
is unfortunate but needed to keep getPath happy.
This code is old, and tricky to modify due to perf optimizations and
edge case behavior. It would be great to refactor more heavily at some
other date. I've spec'd out more of the current behavior and edge cases
in this commit.
Fixes emberjs#3760
mixonic
added a commit
that referenced
this issue
Mar 11, 2015
* Changes globals to only mean properties starting with $ or a capital letter.
* Changes normalizeTuple(obj, 'Foo') to resolve Foo as a global. This
makes the behavior consistent with normalizeTuple(obj, 'Foo.bar') which
already resolves Foo as a global (and looks up bar).
* Changes normalizeTuple(null, 'Foo') to resolve Foo as a global.
* Specs normalizeTuple('null', 'foo') to resolve to [undefined, '']. This
is unfortunate but needed to keep getPath happy.
This code is old, and tricky to modify due to perf optimizations and
edge case behavior. It would be great to refactor more heavily at some
other date. I've spec'd out more of the current behavior and edge cases
in this commit.
Fixes #3760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed this first when looking into a problem I was having with Ember Model which would break on hasMany relations for no apparent reason. This is the related issue.
When the first parameter that’s passed to
Ember.getisnulland thekeyNameis just a toplevel path the lookup is immediately relayed toEmber._getPathwhich finds the property onEmber.lookupor ratherwindow. That’s helpful in a lot of cases but can also return unexpected values as it did in the above situation.Depending on the number of frames on the page
window.lengthin this case returns an integer that’s always>= 0. And even if your application isn’t using frames itself any extension (like the Readability Chrome extension for me) can inject<iframe>s into the page which increases that number.I’m not sure if this is anything you’d want to fix directly in the framework but let me know if you do!
Either way I wanted to bring this up as I didn’t find any existing Issue for it and spent some time tracking down the source—which hopefully someone else looking into the same problem can save now.
The text was updated successfully, but these errors were encountered: