Latest Canary Triggers its own deprecation for barrel file use via @glimmer/component

[runspired]

The utilized APIs are

• Ember._isDestroyed
• Ember._isDestroying
• Ember.destroy
• Ember._registerDestructor

Installed @glimmer/component package is latest 1.x, its never been clear if 2.x is safe to use now, or if the package was even truly used (by being declared but then replaced with the copy from ember-source).

[runspired]

related issues:

• @ember/test-helpers Triggers deprecations for barrel file use on latest ember-source canary ember-test-helpers#1536
• ember-qunit Triggers deprecations for barrel file use on latest ember-source canary ember-qunit#1187

[kategengler]

cc @NullVoxPopuli

[runspired]

I investigated bumping ember-data to use 2.0.0 of @glimmer/component but it fails in our tests against ember 4.8 and older because @ember/owner didn't exist yet. If there's a polyfill for that it seems like we could potentially bump @glimmer/component.

https://github.com/emberjs/data/actions/runs/14011436145/job/39231820841?pr=9780

[NullVoxPopuli]

V2 is safe to use, and the real version is used.
In my try scenarios i swap for v1 in older ember.

[runspired]

@NullVoxPopuli should I just ignore that its kinda a violation that @glimmer/component is currently neither a peer-dep nor a dep of @warp-drive/ember and that swapping for ember-try may only work due to this? (note: it may also not work because the type signature change may prevent it from building correctly)

[NullVoxPopuli]

Yea, i haven't seen anyone find value from declaring @glimmer/component as a peer (Knowingly anyway).

e: it may also not work because the type signature change may prevent it from building correctly)

While the signatures are different, the build should not run again after ember-try sets up the scenario. Build should happen beforehand to better simulate npm conditions

Tho, if you have prepare scripts and such, you may want to toss --ignore-scripts on to the install command that ember-try uses

[NullVoxPopuli]

Related WIP:

• Resolve deprecations from ember barrel file ember-test-helpers#1537
• Resolve ember barrel deprecations ember-qunit#1188
• Deprecation guides for deprecating importing from `'ember'' ember-learn/deprecation-app#1381

[NullVoxPopuli]

This file doesn't exist in latest @glimmer/component, so I think we can close this as being solved by upgrading the the copy of @glimmer/component that is in this repo (v2) 🎉

[kategengler]

I think it should be fine to require @glimmer/component v2 since any version that has the deprecation will support it.

[runspired]

I did successfully bump ember-data to use @glimmer/component for its tests, had to remove usage of a (v1) addon that explicitly brought v1 as a dep which we were using in the fastboot tests. Also had to update type signatures, and add @glimmer/component v1 to the ember-try scenarios for ember-source 3.28, 4.4, and 4.8