[QUEST] RFC 800: TypeScript Adoption Plan Implementation Tracking

[chriskrycho]

RFC 0800 Tracking Issue

Implement RFC 0800: TypeScript Adoption Plan.

Enable TS blueprints

• Enable EMBER_TYPESCRIPT_BLUEPRINTS flag #20352

Publish types

We do not need to publish types for every package in Ember's dependencies—only for the packages which are part of its programmatic public APIs. An example of a dependency we don’t need to ship types with: ember-cli-dependency-checker is integrated into the classic Ember CLI build pipeline, but it doesn’t expose any APIs for users to call. The following list is comprised of the items in the default blueprints filtered for that criteria.

These items will be checked off if they have been "claimed"—please comment if you'd like to claim one! We will track their status via links to the issues/PRs which implement them.

Status: Last updated 2022/12/13, with the dependencies from the app and v1 addon blueprints.

• ember-source (i.e. Ember.js)
  • Publish preview types for Ember #20174
  • [QUEST] Future Public TypeScript Types #19946
• ember-data, including:
  • ember-data
  • @ember-data/adapter
  • @ember-data/canary-features
  • @ember-data/debug
  • @ember-data/deprecations
  • @ember-data/model
  • @ember-data/record-data
  • @ember-data/serializer
  • @ember-data/store
• @ember/optional-features: Convert to TS or supply ambient definitions ember-optional-features#329
• @ember/test-helpers: Convert to TS or supply ambient definitions ember-test-helpers#1268
• @glimmer/component – what we ship here is actually somewhat wrong, but not in a blocking way
• @glimmer/tracking – what we ship here is actually right from a TS POV (unlike the runtime POV!)
• ember-auto-import – already ships types 🎉
• ember-cli: Convert to TS or supply ambient definitions ember-cli/ember-cli#9996
• ember-cli-app-version
• ember-cli-babel
• ember-cli-htmlbars: Convert to TS or supply ambient definitions ember-cli/ember-cli-htmlbars#753
• ember-cli-inject-live-reload
• ember-cli-terser
• ember-fetch – Note: this one is complicated. It already ships types, but badly. Please extra reach out if you pick this one up: a path forward exists but isn't necessarily obvious!
• ember-load-initializers – already ships types! 🎉
• ember-page-title: Convert to TS or supply ambient definitions ember-cli/ember-page-title#239
• ember-qunit: Convert to TS or supply ambient definitions ember-qunit#957
• ember-resolver: Convert to TS or supply ambient definitions ember-cli/ember-resolver#795
• ember-template-lint
• ember-welcome-page: Convert to TS or supply ambient type definitions ember-cli/ember-welcome-page#387
• loader.js¹
• qunit – has reasonably-good types (which we help maintain) on DefinitelyTyped and is not a package we control
• qunit-dom – already ships types! 🎉

Footnotes

1. Debatably, anyway: we could work on dropping this instead, and its public API usage is intended to be minimal; but right now it is a public API. ↩

[bertdeblock]

FYI, the ember-cli-sri repo is archived.

[bertdeblock]

@chriskrycho Seems like a part is missing from the ember-fetch entry in the list above?

[chriskrycho]

Oh, good catches on both points. Updating!

[ijlee2]

@chriskrycho @bertdeblock I'd like to help out with ember-welcome-page.

I think we need to first update the repo (CI, dependencies, and minimum support for Node & Ember), before we introduce TypeScript, though. This would help with future maintenance.

Is it okay if I temporarily own the project and make a few pull requests to keep the project up-to-date and easy to maintain?

[chriskrycho]

Please do! I'll mark is at "taken" here and am happy to help with any TS work there.

[ijlee2]

@chriskrycho Thanks!

[kategengler]

@emberjs/typescript-core Can this be closed?

[gitKrystan]

I think we've completed the high-priority items on this list but not everything. Checking in with @wagenet