Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TS or supply ambient definitions #1268

Closed
chriskrycho opened this issue Nov 29, 2022 · 4 comments
Closed

Convert to TS or supply ambient definitions #1268

chriskrycho opened this issue Nov 29, 2022 · 4 comments

Comments

@chriskrycho
Copy link
Contributor

As part of Ember.js RFC #0800, this package needs to supply type definitions. Preferably, this would happen by converting to TS and generating from the source; as an alternative, it can publish ambient types (presumably starting with the ones on DefinitelyTyped).

All the members of the Typed Ember team are happy to advise on how to do this; feel free to reach out in #dev-typescript on Discord if you have questions!
@chriskrycho chriskrycho mentioned this issue Nov 29, 2022
Open
26 tasks
@gitKrystan
Copy link
Collaborator

I am taking a stab at this. 👍

It should help us resolve emberjs/ember.js#20254 as well.

@gitKrystan
Copy link
Collaborator

Done #1234 :-P

@chriskrycho
Copy link
Contributor Author

Ha! I forgot about that. Also, what a great PR number that was!

@chriskrycho
Copy link
Contributor Author

Talking with @gitKrystan in Discord: she's going to try to get this switched over to using the Ember preview types, and then we'll see about getting a release cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriskrycho @gitKrystan