Incorrect association of props with owner and factory in FactoryManager.create?

[chriskrycho]

This code is either wrong or quite confusing:

ember.js/packages/@ember/-internals/container/lib/container.ts

Lines 507 to 513 in d8f8266

	let props = {};
	setOwner(props, container.owner!);
	setFactoryFor(props, this);
	if (options !== undefined) {
	props = Object.assign({}, props, options);
	}

It appears to be assuming that the setOwner and setFactoryFor will continue to work for props after it is rebound on line 512—but they do not, because it is a completely new object. If I'm reading this method correctly, the original, empty POJO will simply be GC'd, since it's unused after the end of the method.

This has been this way for quite some time, but the cleanups for Ember v4 made it much more apparent.

I believe the correct update here is to change the entire chunk to simply be:

let props = options ? { ...options } : {};
setOwner(props, container.owner!);
setFactoryFor(props, this);

That would maintain the object identity and therefore make owner and factory lookups for this props object continue to work correctly.