[Bug] Template compiler crash on 3.28.2

[ef4]

🐞 Describe the Bug

The template compiler crashes with

@ember/test-helpers/setup-rendering-context.js: Cannot read property 'indexOf' of null

This is fallout from glimmerjs/glimmer-vm#1351 and glimmerjs/glimmer-vm#1352

The problem is that Glimmer declares the locals argument to be of type:

locals?: string[];

But babel-plugin-htmlbars-inline-precompile sends null.

This wasn't noticed before because for any non-strict template the locals argument used to be ignored. But now it's respected, and null is not a valid value.

🔬 Minimal Reproduction

Update a newly generated app to ember-source 3.28.2.

[simonihmig]

For the record: I see this also happening for latest beta and canary releases.

[Turbo87]

@rwjblue @ef4 I think we might have to reopen this issue. rust-lang/crates.io#4073 is still showing the same bug, even with v3.28.3.

[rwjblue]

@Turbo87 ya, I messed up the backport 🤦

I've tested with local builds on 3.28.3 and 3.28.4 (before pushing the tag), once https://github.com/emberjs/ember.js/actions/runs/1373035405 is completed 3.28.4 will be published with the fix.

[simonihmig]

@rwjblue what about beta, can we get the fix out there too? I see all addon scenarios for beta failing. (example)

Recently set up renovate for a few addons, now getting dozens of failing PRs... 🙈.🙃

[Turbo87]

Recently set up renovate for a few addons, now getting dozens of failing PRs... 🙈.🙃

at least renovate has a "rebase all PRs" option 😅

ya, I messed up the backport 🤦

no worries, thanks for fixing so fast! ❤️

[simonihmig]

@rwjblue thank you! 🙏