[Bug] template-compiler is not usable with Embroider(staticAddonTrees: true) + ember 3.27

[NullVoxPopuli]

🐞 Describe the Bug

The template compiler cannot be used with Ember 3.27 (modules! 🎉 ) and embroider:

🔬 Minimal Reproduction

https://github.com/NullVoxPopuli/repro-emberjs-16568

😕 Actual Behavior

This error occurs when calling compile:

Error: Cannot call `compile` with only the template compiler loaded. Please load `ember.debug.js` or `ember.prod.js` prior to calling `compile`.

🤔 Expected Behavior

compile succeeds as it does with Ember 3.26

🌍 Environment

• Ember: - 3.27.2
• Node.js/npm: - 4.17.0
• OS: - Ubuntu 20.04
• Browser: - FireFox Developer Edition 89.0b15 (64-bit)

➕ Additional Context

deployed repro here:

• Update dependency ember-source to v3.27.2 NullVoxPopuli/limber#60
• https://60b116dddcec312d2a935201--limber.netlify.app/

[ef4]

All ember internal use of this pattern:

ember.js/packages/ember-template-compiler/lib/system/compile.ts

Line 4 in 21bd70c

import require, { has } from 'require';

Needs to stop. We have replacements already (in @embroider/macros) that work in both non-embroider and embroider builds.

[NullVoxPopuli]

@ef4 do you have an example Pr or anything of what it takes to swap out that require stuff with @embroider/macros? I could try PRing those changes to the template-compiler and other places in ember

[NullVoxPopuli]

wip: #19569

[rwjblue]

All ember internal use of this pattern:

ember.js/packages/ember-template-compiler/lib/system/compile.ts

Line 4 in 21bd70c

import require, { has } from 'require';

Needs to stop. We have replacements already (in @embroider/macros) that work in both non-embroider and embroider builds.

Obviously you are correct, but the compat adapter that Embroider ships could easily handle these cases.

[NullVoxPopuli]

I've tried reproing here: https://github.com/NullVoxPopuli/repro-emberjs-16568/blob/main/app/routes/application.js#L25
but it's working, so I have more digging to do

[NullVoxPopuli]

ah! success! (I have minimal reproduction)
all I needed was to add this:

    staticAddonTrees: true,
    staticAddonTestSupportTrees: true,
    staticHelpers: true,
    staticComponents: true,
    splitControllers: true,
    splitRouteClasses: true,

to my embroider config: NullVoxPopuli/repro-emberjs-16568@89e8699

[NullVoxPopuli]

in particular, staticAddonTrees: true causes this error

[NullVoxPopuli]

This is no longer an issue with https://github.com/NullVoxPopuli/ember-repl/
(but probably other reasons, too 🤷 )