-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 297] Deprecation Ember.Logger #16231
Comments
Locally, as of last weekend...
...I get busy elsewhere during the week. I'm hoping to have the deprecation itself completed, feature flag and all, this weekend, or before the RFC exits FCP. I'm not sure of the most comprehensive way to review the API docs besides bulk searches on the source, which I've been doing anyway. I think I've done the right things in the code comments to properly mark the deprecation but have no idea how to build the API docs to see the final effect. That leaves the codemod and the review of the addons, for which I will need a little help. |
So far, we have the following PRs: |
I encountered a couple of unexpected speed-bumps using console in Edge and IE11. The simple page in the attachment can be used to easily observe the console uses that pose a problem and their easy workarounds. Try it in Edge and IE11 with and without the developer tools up, then try it in other browsers. tryconsole.zip |
Uh-oh. I just realized, walking emberobserver, that we didn’t have ember-resolver on the above list. So many projects... |
@lupestro not sure I understand? |
In wake of our discussion @locks, here’s the issue over on ember-resolver: |
Great job!! |
Is there a codemod or any other discussion for this deprecation? |
There has been discussion for it. We captured prior discussion in the RFC itself, the PR for the RFC carries further discussion, and the deprecation text describes what needs to change, and what you have to do to deal with the one or two remaining oddities of console in IE11 and Edge. There is no codemod to automate changing the code, as the work can involve a little judgment, but the changes are generally very local and simple, as the deprecation text tries to show. The RFC references some of the code that we examined in determining the impact of the change. In all the code we looked at, it seemed straightforward to find and make any needed changes by hand. |
RFC: emberjs/rfcs#297
While the RFC is not merged yet, it was recently moved into Final Comment Period and there is general support for this to land, so we feel confident that work can commence in preparation.
Tasks
The text was updated successfully, but these errors were encountered: