Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Outlet Orphaning #14097

Closed
chadhietala opened this issue Aug 19, 2016 · 2 comments
Closed

Deprecate Outlet Orphaning #14097

chadhietala opened this issue Aug 19, 2016 · 2 comments

Comments

@chadhietala
Copy link
Contributor

This is a relic that did get cut in 2.0.0 and we should part ways with. It is used when you have a {{render}} helper in the route template and you render into it from the route. As you render into it you will come across an {{outlet}} that is orphaned. You now need to reason about what should go into that outlet.

The path that will be deprecated.

/cc @ef4

@chancancode
Copy link
Member

We can probably just deprecate {{render}}?

@ef4
Copy link
Contributor

ef4 commented Aug 30, 2016

Yes, deprecating {{render}} solves this.

There's a related behavior that makes sense to deprecate with it, which is
calling Route#render any time other than within the renderTemplate
hook. Last time this came up the objection was that we need to show a
better alternative for sidebar and modal rendering, which now exists in
ember-elsewhere.

With that, we can cut a bunch of complexity out.

On Aug 30, 2016 4:03 AM, "Godfrey Chan" [email protected] wrote:

We can probably just deprecate {{render}}?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14097 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATfMlqQtlBpJ7of0B_RkMR0MK0xJIwnks5qk-PGgaJpZM4JomV1
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants