FillIn acceptance helper works only on the first matched input

[piotrpalek]

I tried to fillIn multiple inputs in an acceptance test with one selector. So let's say my template was:

{{input value=someVal}}
{{input value=otherVal}}

And I was using fillIn like this: fillIn('input', 'someval')

The result would be that visually it would seem as if both inputs are filled in with the same value (html was updated), but the data binding would only be updated on someVal.

Replicated here: https://ember-twiddle.com/63d30b6cde4d82491c0def9bcc36ef28

(sidenote: I couldn't use Ember 2.7 due to a twiddle bug, but the same thing is happening in an app using Ember 2.7)

[piotrpalek]

Ok so the issue seems to be that the fillIn helper uses the first element of the collection it finds for most of the work, but uses the whole collection to set the value:

ember.js/packages/ember-testing/lib/helpers/fill_in.js

Line 14 in 86d6862

$el.val(text);

Question is what's the expected behavior, to only work on the first element or to work on all found elements?

[pixelhandler]

@piotrpalek I'm curious if you are more explicit with the selector you use with fillIn to only find one input does the helper work as expected?

See: this twiddle it uses a more specific selected to fillIn https://ember-twiddle.com/053b51712bc76076ec1200645b813b17?fileTreeShown=false&openFiles=tests.acceptance.my-acceptance-test.js%2C

I think that the expectation is that the fillIn helper should use a specific selector for a single input.

I do not think this is a bug.

[piotrpalek]

@pixelhandler being able to make the selector more specific isn't the issue. The issue is that the behavior is inconsistent when having a selector that matches multiple inputs. It should either only work for the first element in case of multiple inputs, or work consistently for all of them.

Right now when you try to fillIn multiple inputs it seems as if it's working but actually isn't, that is very clearly a bug in my opinion.

As for the question if it should work for multiple elements. I think that if the guides say that it expects a selector for the input, without specifying that it will only work for the first matched element, then it would be expected that it can work on all of the elements that the selector finds, not only for the first item. But that's something that can be agreed on.

[Serabe]

Thank you, @piotrpalek! The PR has just been merged and there is a comment in the Grand Testing Unification RFC you might be interested in.

Thank you!

[piotrpalek]

@Serabe np 👍