attrs not updating correctly for contextual components

[amk221]

Please see the console on this twiddle

Edit: Sorry, badly named issue. Not sure what the actual problem is just yet.

[rwjblue]

Haven't dug into exactly what is happening just yet, but this is definitely a bug.

[Serabe]

While working on #12617 I'm also taking a look at this since both seem to touch the same classes.

I have notice that attrs is different in each case on rerender. It contains the right value in my-component but not in my-nested-component. I need to see how the closure component relates to the rerender.

[Serabe]

I think I know what is happening. I'll check tonight (your this morning)

[Serabe]

Submitted a PR fixing this. The shortcat for rerendering was being done to soon preventing the arguments from the closure component to be passed to state.manager.rerender.

[amk221]

@Serabe Thanks for your work on the fix. Would you be able to look at the updated twiddle. I've tried to clarify what I am expecting the behaviour to actually be (see the console).

Essentially, I think that didReceiveAttrs is not firing with the correct value. But I might be expecting the wrong thing.

[rwjblue]

Reopening for review.

[Serabe]

I think when Ember Twiddle updates with the fix it should be ok. @rwjblue do you know if there is a way to test a twiddle with current master?

[rwjblue]

https://ember-twiddle.com/5a29d14617527134ecad?numColumns=1 seems to be working properly (and using the correct SHA of Ember canary).

@amk221 - Can you confirm?

[amk221]

Confirm, it's working. Thanks!
(Apologies, miscommunication between myself and rwjblue on Slack)

[amk221]

The RFC suggests I should be able to send along additional attributes to contextual components.

If you add foo='bar' as an attr to the contextual component in the twiddle, then the 'additional attribute' is not additional, but seems to wipe out the closed over attributes.

[Serabe]

Please, can you send the updated tweedle? I did this and seems to work.

[amk221]

@Serabe Yup, that's what I did too. Notice the difference in the console when you add that extra attribute? myProp does not increment, but it should?

[Serabe]

I see now. Proper support for glimmer components are still in the making. I'll take this into account. Thank you.

[amk221]

Ok thanks, this blocks a feature I need to create a select box component - is there a place I can track this issue?

[Serabe]

The PR referenced above