avoid boolean coercion in property_set

emberjs · Oct 2, 2017 · cbb0ecb · cbb0ecb
1 parent 04b6f42
commit cbb0ecb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/ember-metal/lib/meta.js b/packages/ember-metal/lib/meta.js
@@ -343,7 +343,7 @@ export class Meta {
   }
 
   peekWatching(subkey) {
-   return this._findInherited('_watching', subkey);
+    return this._findInherited('_watching', subkey);
   }
 
   writeMixins(subkey, value) {

diff --git a/packages/ember-metal/lib/property_set.js b/packages/ember-metal/lib/property_set.js
@@ -5,7 +5,6 @@ import {
   propertyWillChange,
   propertyDidChange
 } from './property_events';
-
 import {
   isPath
 } from './path_cache';
@@ -98,10 +97,9 @@ function setPath(root, path, value, tolerant) {
   assert('Property set failed: You passed an empty path', keyName.trim().length > 0)
 
   let newPath = parts.join('.');
-
   let newRoot = getPath(root, newPath);
 
-  if (newRoot) {
+  if (newRoot !== null && newRoot !== undefined) {
     return set(newRoot, keyName, value);
   } else if (!tolerant) {
     throw new EmberError(`Property set failed: object in path "${newPath}" could not be found or was destroyed.`);