Skip to content

Commit

Permalink
Merge pull request #10678 from matthooks/master
Browse files Browse the repository at this point in the history
Fix typos in deprecations of unescaped style attribute
  • Loading branch information
stefanpenner committed Mar 20, 2015
2 parents d9fa588 + 61cb273 commit 7b58afc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/ember-htmlbars/tests/attr_nodes/style_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ QUnit.test('specifying `<div style="width: {{userValue}}></div>` is [DEPRECATED]

expectDeprecation(function() {
runAppend(view);
}, /Dynamic content in the `style` attribute is not escaped and may pose a security risk. Please preform a security audit and once verified change from `<div style="foo: {{property}}">` to `<div style="foo: {{{property}}}">/);
}, /Dynamic content in the `style` attribute is not escaped and may pose a security risk. Please perform a security audit and once verified change from `<div style="foo: {{property}}">` to `<div style="foo: {{{property}}}">/);
});

QUnit.test('specifying `<div style="width: {{{userValue}}}></div>` works properly', function() {
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-htmlbars/tests/helpers/bind_attr_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ QUnit.test('specifying `<div {{bind-attr style=userValue}}></div>` is [DEPRECATE

expectDeprecation(function() {
runAppend(view);
}, /Dynamic content in the `style` attribute is not escaped and may pose a security risk. Please preform a security audit and once verified change from `<div {{bind-attr style=someProperty}}>` to `<div style={{{someProperty}}}>/);
}, /Dynamic content in the `style` attribute is not escaped and may pose a security risk. Please perform a security audit and once verified change from `<div {{bind-attr style=someProperty}}>` to `<div style={{{someProperty}}}>/);
});

QUnit.test('specifying `<div {{{bind-attr style=userValue}}}></div>` works properly', function() {
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-views/lib/attr_nodes/attr_node.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ AttrNode.prototype.render = function render(buffer) {
AttrNode.prototype._deprecateEscapedStyle = function AttrNode_deprecateEscapedStyle(value) {
Ember.deprecate(
'Dynamic content in the `style` attribute is not escaped and may pose a security risk. ' +
'Please preform a security audit and once verified change from ' +
'Please perform a security audit and once verified change from ' +
this._dynamicStyleDeprecationMessage,
(function(name, value, escaped) {
// SafeString
Expand Down

0 comments on commit 7b58afc

Please sign in to comment.