[CLEANUP beta] Remove bind-attr

emberjs · Jul 8, 2015 · 642f5c3 · 642f5c3
1 parent c3f15cf
commit 642f5c3
Show file tree

Hide file tree

Showing 16 changed files with 23 additions and 1,131 deletions.
diff --git a/packages/ember-htmlbars/lib/helpers/-bind-attr-class.js b/packages/ember-htmlbars/lib/helpers/-bind-attr-class.js
diff --git a/packages/ember-htmlbars/lib/helpers/bind-attr.js b/packages/ember-htmlbars/lib/helpers/bind-attr.js
diff --git a/packages/ember-htmlbars/lib/main.js b/packages/ember-htmlbars/lib/main.js
@@ -23,7 +23,6 @@ import locHelper from 'ember-htmlbars/helpers/loc';
 import logHelper from 'ember-htmlbars/helpers/log';
 import eachHelper from 'ember-htmlbars/helpers/each';
 import eachInHelper from 'ember-htmlbars/helpers/each-in';
-import bindAttrClassHelper from 'ember-htmlbars/helpers/-bind-attr-class';
 import normalizeClassHelper from 'ember-htmlbars/helpers/-normalize-class';
 import concatHelper from 'ember-htmlbars/helpers/-concat';
 import joinClassesHelper from 'ember-htmlbars/helpers/-join-classes';
@@ -51,7 +50,6 @@ registerHelper('each', eachHelper);
 if (isEnabled('ember-htmlbars-each-in')) {
   registerHelper('each-in', eachInHelper);
 }
-registerHelper('-bind-attr-class', bindAttrClassHelper);
 registerHelper('-normalize-class', normalizeClassHelper);
 registerHelper('concat', concatHelper);
 registerHelper('-join-classes', joinClassesHelper);

diff --git a/packages/ember-htmlbars/tests/compat/make_bound_helper_test.js b/packages/ember-htmlbars/tests/compat/make_bound_helper_test.js
@@ -10,9 +10,7 @@ import { A } from 'ember-runtime/system/native_array';
 import { get } from 'ember-metal/property_get';
 import { set } from 'ember-metal/property_set';
 import { runAppend, runDestroy } from 'ember-runtime/tests/utils';
-import {
-  dasherize
-} from 'ember-runtime/system/string';
+import { dasherize } from 'ember-runtime/system/string';
 
 import EmberHandlebars from 'ember-htmlbars/compat';
 import { deprecation as eachDeprecation } from 'ember-htmlbars/helpers/each';
@@ -98,20 +96,24 @@ QUnit.test('should update bound helpers in a subexpression when properties chang
     return dasherize(value);
   });
 
+  helper('reverse', function(value) {
+    return value.split('').reverse().join('');
+  });
+
   ignoreDeprecation(function() {
     view = EmberView.create({
       controller: { prop: 'isThing' },
-      template: compile('<div {{bind-attr data-foo=(dasherize prop)}}>{{prop}}</div>')
+      template: compile('<div data-foo="{{reverse (dasherize prop)}}">{{prop}}</div>')
     });
   });
 
   runAppend(view);
 
-  equal(view.$('div[data-foo="is-thing"]').text(), 'isThing', 'helper output is correct');
+  equal(view.$('div[data-foo="gniht-si"]').text(), 'isThing', 'helper output is correct');
 
   run(view, 'set', 'controller.prop', 'notThing');
 
-  equal(view.$('div[data-foo="not-thing"]').text(), 'notThing', 'helper output is correct');
+  equal(view.$('div[data-foo="gniht-ton"]').text(), 'notThing', 'helper output is correct');
 });
 
 QUnit.test('should allow for computed properties with dependencies', function() {