Skip to content

Commit

Permalink
Introduce new @ember/routing sub-modules
Browse files Browse the repository at this point in the history
Add the `@ember/routing/transition` and `@ember/routing/route-info`,
per RFC 0821. These match the existing public preview types.
  • Loading branch information
chriskrycho committed Nov 16, 2022
1 parent 8497a5b commit 6383470
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
8 changes: 8 additions & 0 deletions packages/@ember/routing/route-info.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* Provides the `RouteInfo` and `RouteInfoWithMetadata` types which appear as
* the target and source routes for `Transition`s.
*
* @module @ember/routing/route-info
*/

export type { RouteInfo as default, RouteInfoWithAttributes } from './lib/route-info';
8 changes: 8 additions & 0 deletions packages/@ember/routing/transition.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* Provides the `Transition` type which are used in Ember's routing transitions,
* e.g. `RouterService.on('routeDidChange', (transition) => { ... })`.
*
* @module @ember/routing/transition
*/

export type { Transition as default } from 'router_js';
1 change: 0 additions & 1 deletion types/preview/@ember/routing/route-info.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
declare module '@ember/routing/route-info' {
// https://api.emberjs.com/ember/4.0/classes/RouteInfo
/**
* A `RouteInfo` is an object that contains metadata about a specific route within a `Transition`.
* It is read-only and internally immutable.
Expand Down

0 comments on commit 6383470

Please sign in to comment.