ensure async helpers are inlined in dev

emberjs · Aug 21, 2019 · 4bf158f · 4bf158f
1 parent c74c82b
commit 4bf158f
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 15 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -72,6 +72,10 @@ module.exports = {
     let appOptions = this.app && this.app.options;
     let babelOptions = (parentOptions || appOptions || {}).babel;
 
+    // We want to enable async/generator helpers if we are developing locally,
+    // but not for any other project.
+    let isEmberSource = this.project.name() === 'ember-source';
+
     let options = {
       'ember-cli-babel': {
         disableDebugTooling: true,
@@ -80,7 +84,7 @@ module.exports = {
       babel: Object.assign({}, babelOptions, {
         loose: true,
         plugins: [
-          injectBabelHelpers,
+          injectBabelHelpers(isEmberSource),
           buildDebugMacroPlugin(!isProduction),
           [
             require.resolve('@babel/plugin-transform-block-scoping'),

diff --git a/lib/transforms/inject-babel-helpers.js b/lib/transforms/inject-babel-helpers.js
@@ -2,21 +2,30 @@
 
 const { addNamed } = require('@babel/helper-module-imports');
 
-function injectBabelHelpers() {
-  return {
-    pre(file) {
-      file.set('helperGenerator', function(name) {
-        if (name === 'extends') {
-          return addNamed(file.path, 'assign', '@ember/polyfills');
-        }
-        return addNamed(file.path, name, 'ember-babel');
-      });
-    },
+function injectBabelHelpers(isEmberSource = false) {
+  function injectBabelHelpersPlugin() {
+    return {
+      pre(file) {
+        file.set('helperGenerator', function(name) {
+          if (name === 'extends') {
+            return addNamed(file.path, 'assign', '@ember/polyfills');
+          } else if (isEmberSource && name === 'asyncToGenerator') {
+            // Returning a falsy value will cause the helper to be inlined,
+            // which is fine for local tests
+            return false;
+          }
+
+          return addNamed(file.path, name, 'ember-babel');
+        });
+      },
+    };
+  }
+
+  injectBabelHelpersPlugin.baseDir = function() {
+    return 'babel-core';
   };
-}
 
-injectBabelHelpers.baseDir = function() {
-  return 'babel-core';
-};
+  return injectBabelHelpersPlugin;
+}
 
 module.exports = injectBabelHelpers;