Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure setting an empty value in FileInput clears the selected files #924

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Ensure setting an empty value in FileInput clears the selected files #924

merged 3 commits into from
Oct 20, 2020

Conversation

nag5000
Copy link
Contributor

@nag5000 nag5000 commented Oct 20, 2020

It fixes #920

rwjblue
rwjblue approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for fixing this!!!

@rwjblue rwjblue added the bug label Oct 20, 2020
@rwjblue rwjblue merged commit ea60f0e into emberjs:master Oct 20, 2020
@nag5000 nag5000 deleted the fix/setting-empty-value-clears-files branch October 20, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

input[type=file].value = '' does not reset input.files after triggerEvent
2 participants
@nag5000 @rwjblue