Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to waitUntil and waitFor #750

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Add examples to waitUntil and waitFor #750

merged 3 commits into from
Feb 5, 2020

Conversation

jenweber
Copy link
Contributor

I personally need this reminder. I keep forgetting to await and return things.

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

the API.md file is automatically generated though, you will have to add those examples to the source code comments too

@Turbo87 Turbo87 changed the title [DOC] Add examples to waitUntil and waitFor Add examples to waitUntil and waitFor Jan 21, 2020
@scalvert
Copy link
Contributor

👍 this is great. I agree we needed examples.

@jenweber jenweber requested a review from Turbo87 January 24, 2020 00:31
@jenweber
Copy link
Contributor Author

Hi @Turbo87, this is ready for another review. Apologies for taking so long to update this. I added the examples into the source code and regenerated API.md using yarn docs. Some of the diff in the md is from preexisting changes in the source that look like they didn't get built in yet.

Let me know if anything else is needed here!

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏

@rwjblue rwjblue merged commit e609749 into master Feb 5, 2020
@rwjblue rwjblue deleted the waitfor-until-docs branch February 5, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants