Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for triggerEvent #663

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Update documentation for triggerEvent #663

merged 2 commits into from
Jun 11, 2019

Conversation

qpowell
Copy link
Contributor

@qpowell qpowell commented Jun 7, 2019 •
edited
Loading

  • Fixes missing line break in first triggerEvent example, and adds the files key to the options object.
  • Includes additional example for working with the drop event.

Update 'triggerEvent' examples
bf014a4 
- Fix missing line break in first `triggerEvent` example.
- Include additional example for simulating the `drop` event.
rwjblue
rwjblue reviewed Jun 7, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

The API.md file is auto-generated from the inline API documentation (in the JS / TS files), would you mind tweaking this to update this file instead?

https://github.com/emberjs/ember-test-helpers/blob/master/addon-test-support/@ember/test-helpers/dom/trigger-event.ts

@qpowell
Copy link
Contributor Author

qpowell commented Jun 7, 2019

Thanks for working on this!

The API.md file is auto-generated from the inline API documentation (in the JS / TS files), would you mind tweaking this to update this file instead?

https://github.com/emberjs/ember-test-helpers/blob/master/addon-test-support/@ember/test-helpers/dom/trigger-event.ts

Yeah, no problem!

rwjblue
rwjblue reviewed Jun 11, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@rwjblue rwjblue merged commit fe81329 into emberjs:master Jun 11, 2019
@rwjblue rwjblue changed the title Update 'triggerEvent' examples Update documentation for triggerEvent Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qpowell @rwjblue