Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use container to register custom DS keys. #34

Merged
merged 1 commit into from
Apr 4, 2015

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Apr 4, 2015

registry is not necessarily avaiable in this context.

`registry` is not necessarily avaiable in this context.
dgeb added a commit that referenced this pull request Apr 4, 2015
Use container to register custom DS keys.
@dgeb dgeb merged commit f90ec56 into master Apr 4, 2015
@rwjblue
Copy link
Member

rwjblue commented Apr 4, 2015

Great catch, sorry about that!

@rwjblue rwjblue deleted the fix-isolated-container-ds-hack branch April 4, 2015 22:27
@dgeb
Copy link
Member Author

dgeb commented Apr 4, 2015

No prob, @rwjblue! Just make sure to use v0.4.3 in ember-qunit.

@rwjblue
Copy link
Member

rwjblue commented Apr 5, 2015

Hopefully #35 prevents this in the future...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants