Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to QUnit 2.5.0. #315

Merged
merged 4 commits into from
Feb 10, 2018
Merged

Update to QUnit 2.5.0. #315

merged 4 commits into from
Feb 10, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Feb 10, 2018

  • Contains assert.rejects
  • Reduces the delays around assert.async and returning promises from
    hook methods.
  • Adds a native promise unhandled rejection handler
  • Fixes an issue with notrycatch mode being ignored for promises
    returned (e.g. it would previously always .catch every returned
    promise).

* Contains `assert.rejects`
* Reduces the delays around `assert.async` and returning promises from
  hook methods.
* Adds a native promise unhandled rejection handler
* Fixes an issue with `notrycatch` mode being ignored for promises
  returned (e.g. it would previously always `.catch` every returned
  promise).
The assert.rejects API changed after the original polyfill was written.
Now it accepts the promise directly...
@rwjblue rwjblue merged commit 37c4139 into emberjs:master Feb 10, 2018
@rwjblue rwjblue deleted the update-qunit-2-5 branch February 10, 2018 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants