Use "real" rootElement for DOM interaction helpers. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Dec 30, 2017
| rootElement = '#ember-testing'; | ||
| } else { | ||
| rootElement = owner.rootElement; | ||
| } |
There was a problem hiding this comment.
Why is this not using the extracted helper function?
There was a problem hiding this comment.
good point, I'll double check that all supported ember versions support calling appendTo with an actual element (as opposed to a selector string, which is being used here), but I totally agree that it makes sense to avoid double encoding this concept (and is why I removed the complete hard coding to begin with).
rwjblue
force-pushed
the
root-element-tweaks
branch
from
b5e4d2b
to
5b2d7db
Compare
This brings setupRenderingContext in line with setupApplicationContext, and now properly uses the specified `rootElement`. Prior to this, when using `setApplication(...)` with a different `rootElement` set than `#ember-testing` the event dispatcher would be setup to listen on a different element than the one that is actually being rendered into...
Using `Node.prototype.nodeType` is a better way to detect this...
The utility is private for now, but may be made public in the future (needs more docs at the least). The basic gist is that `getRootElement` should search relative to the `rootElement` of the application (when `setApplication` was used), and _not_ scoped to the first `.ember-view` _inside_ that element. This ensures that elements added to the `rootElement` (e.g. via `ember-wormhole` / `liquid-wormhole`) can also be interacted with.
The tests previosly avoided using `setupContext` / `setupRenderingContext` / `setupApplicationContext` and instead relied on internal private API details around _how_ the selectors are found. This refactors the DOM interaction helper tests to use `setupContext`, which is much closer to "reality"...
The tests use `setupContext` / `setupRenderingContext` which do not work in Ember 2.0.0.
rwjblue
force-pushed
the
root-element-tweaks
branch
from
c926272
to
0dbcb31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts a
getRootElementutility function (used bygetElementandwaitFor). The utility is private for now, but may be made public in the future (needs more docs at the least).The basic gist is that
getRootElementshould search relative to therootElementof the application (whensetApplicationwas used), and not scoped to the first.ember-viewinside that element. This ensures that elements added to therootElement(e.g. viaember-wormhole/liquid-wormhole) can also be interacted with.Also updates
setupRenderingContextto use the applications designatedrootElement(as opposed to always using#ember-testing). This bringssetupRenderingContextin line withsetupApplicationContext, and now properly uses the specifiedrootElement.Prior to this, when using
setApplication(...)with a differentrootElementset than#ember-testingthe event dispatcher would be setup to listen on a different element than the one that is actually being rendered into...