Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor settled to leverage waitUntil. #292

Merged
merged 1 commit into from
Dec 30, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 30, 2017

Migrates ramp up functionality to waitUntil and migrates settled to leverage waitUntil.

@rwjblue
Copy link
Member Author

rwjblue commented Dec 30, 2017

Note: I didn't update documentation mostly because exactly how we wait seems like an implementation detail and not really the actual API...

@rwjblue rwjblue requested a review from Turbo87 December 30, 2017 04:10
});
return waitUntil(
() => {
return isSettled(options);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could use shorthand arrow function syntax to simplify the code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sounds good. Will update.


import { nextTick } from './-utils';
const TIMEOUTS = [0, 1, 2, 5, 7];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I added another entry. Does It seem bad?

Migrates ramp up functionality to `waitUntil` and migrates `settled` to
leverage `waitUntil`.
@rwjblue rwjblue merged commit 9eb3e32 into emberjs:master Dec 30, 2017
@rwjblue rwjblue deleted the refactor-wait-until branch December 30, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants